Skip to content

Fixes #1711. Ensure change event fires when same image is selected. #1718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miketaylr merged 3 commits into from
Aug 21, 2017
Merged

Fixes #1711. Ensure change event fires when same image is selected. #1718

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
61c7067
Issue #1711. Null out input value after checkImageTypeValidity.
Aug 15, 2017
e405142
Issue #1711. Blur the removeBanner button to avoid a focus outline.
Aug 15, 2017
992cff4
Issue #1711. Test that "double image selection" works.
Aug 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Issue #1711. Test that "double image selection" works.
  • Loading branch information
Mike Taylor committed Aug 16, 2017
commit 992cff4dca7526a4a148265778589096d6a92751
26 changes: 26 additions & 0 deletions tests/functional/image-uploads-non-auth.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,32 @@ define(
})
.end()
);
},

"double image select works": function() {
return FunctionalHelpers.openPage(this, url, ".wc-UploadForm-button")
.findById("image")
.type("tests/fixtures/green_square.png")
.sleep(1000)
.end()
.findByCssSelector(".js-image-upload-label .wc-UploadForm-button")
.click()
.sleep(1000)
.end()
.findById("image")
.type("tests/fixtures/green_square.png")
.end()
.sleep(1000)
.findByCssSelector(".js-image-upload-label")
.getAttribute("style")
.then(function(inlineStyle) {
assert.include(
inlineStyle,
"data:image/png;base64,iVBOR",
"Preview is shown"
);
})
.end();
}
});
}
Expand Down