Skip to content

Fixes #1850. Remove redundant test for details param.#1956

Merged
zoepage merged 1 commit intomasterfrom
issues/1850/1
Dec 5, 2017
Merged

Fixes #1850. Remove redundant test for details param.#1956
zoepage merged 1 commit intomasterfrom
issues/1850/1

Conversation

@miketaylr
Copy link
Copy Markdown
Member

This is already tested @

"details param adds info to description": function() {
return FunctionalHelpers.openPage(
this,
url("/issues/new?details=" + DETAILS_STRING),
"#description"
)
.findByCssSelector("#steps_reproduce")
.getProperty("value")
.then(function(text) {
assert.include(
text,
"Encountered error: NS_ERROR_DOM_MEDIA_DEMUXER_ERR (0x806e000c)\nLocation: virtual\nRefPtrMP4Demuxer::InitPromise mozilla::MP4Demuxer::Init()\nError information:\nIncomplete MP4 metadata\nMedia URL: file:///Users/potch/Documents/mozilla/media.mp4"
);
})
.end();
},

@miketaylr
Copy link
Copy Markdown
Member Author

r? @zoepage

@zoepage
Copy link
Copy Markdown
Member

zoepage commented Dec 5, 2017

LTGM.

@zoepage zoepage merged commit e7e63ba into master Dec 5, 2017
@zoepage zoepage deleted the issues/1850/1 branch December 5, 2017 09:37
@miketaylr
Copy link
Copy Markdown
Member Author

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants