Fix #1995 - Adds proper unicode handling for Form data#1998
Merged
miketaylr merged 4 commits intowebcompat:masterfrom Jan 4, 2018
Merged
Fix #1995 - Adds proper unicode handling for Form data#1998miketaylr merged 4 commits intowebcompat:masterfrom
miketaylr merged 4 commits intowebcompat:masterfrom
Conversation
Make sure the URL is treated as a unicode string and that it doesn’t break down the pipe when manipulating it.
Fixing this because it is a secondary break uncovered in the 1995 issue.
Member
Author
|
r? @miketaylr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue that @softvision-oana-arbuzov found and a couple of others related to unicode in the form (that were not seen before because of breaking in cascade).
form tests are passing. Added a couple of tests.
And the general unittests are still passing.