Skip to content

Fix #1995 - Adds proper unicode handling for Form data#1998

Merged
miketaylr merged 4 commits intowebcompat:masterfrom
karlcow:1995/1
Jan 4, 2018
Merged

Fix #1995 - Adds proper unicode handling for Form data#1998
miketaylr merged 4 commits intowebcompat:masterfrom
karlcow:1995/1

Conversation

@karlcow
Copy link
Copy Markdown
Member

@karlcow karlcow commented Jan 4, 2018

This fixes the issue that @softvision-oana-arbuzov found and a couple of others related to unicode in the form (that were not seen before because of breaking in cascade).

→ nosetests -v --nocapture tests/test_form.py
Statuses Initialization…
Fetching milestones from Github…
Milestones saved in data/
Milestones in memory
The data body sent to GitHub API. ... ok
Check that domain name is extracted. ... ok
Checks we return the right form with the appropriate data. ... ok
HTML comments need the right values depending on the keys. ... ok
Check that metadata is processed and wrapped. ... ok
Avoid some type of strings. ... ok
Check that URL is normalized. ... ok
Check that appropriate radio button label is returned. ... ok

----------------------------------------------------------------------
Ran 8 tests in 0.007s

OK

form tests are passing. Added a couple of tests.

And the general unittests are still passing.

→ nosetests --nocapture
Statuses Initialization…
Fetching milestones from Github…
Milestones saved in data/
Milestones in memory
........................................................................
----------------------------------------------------------------------
Ran 72 tests in 2.060s

OK

Make sure the URL is treated as a unicode string and that it doesn’t
break down the pipe when manipulating it.
Fixing this because it is a secondary break uncovered in the 1995 issue.
@karlcow karlcow requested review from miketaylr and zoepage January 4, 2018 04:09
@karlcow
Copy link
Copy Markdown
Member Author

karlcow commented Jan 4, 2018

r? @miketaylr
r? @zoepage

Copy link
Copy Markdown
Member

@miketaylr miketaylr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks karl

@miketaylr miketaylr merged commit 619926a into webcompat:master Jan 4, 2018
@karlcow karlcow deleted the 1995/1 branch March 30, 2018 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants