Fixes #2420 - Adds tolerance on milestones initialization#2426
Merged
miketaylr merged 1 commit intowebcompat:masterfrom Apr 26, 2018
Merged
Fixes #2420 - Adds tolerance on milestones initialization#2426miketaylr merged 1 commit intowebcompat:masterfrom
miketaylr merged 1 commit intowebcompat:masterfrom
Conversation
miketaylr
reviewed
Apr 26, 2018
| # This is probably fine, but we can log a warning. | ||
| if set(status_names) < set(milestone_names): | ||
| # Extract the additional milestones | ||
| intruder = set(status_names).symmetric_difference(set(milestone_names)) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
miketaylr
approved these changes
Apr 26, 2018
miketaylr
added
status: add to changelog
in progress
and removed
in progress
status: add to changelog
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @miketaylr
This adds more tolerance on milestones initialization.
It will fail for missing milestones.
But just log a warning for additional milestones, which is the most likely case.