Fixes #2487. webcompat site: tweak/remove aria-label in footer links, make search form in top nav only focusable when visible#2489
Merged
miketaylr merged 2 commits intowebcompat:masterfrom Jun 7, 2018
Conversation
miketaylr
approved these changes
Jun 7, 2018
Member
miketaylr
left a comment
miketaylr
left a comment
There was a problem hiding this comment.
Awesome, thanks so much @patrickhlauke.
Member
|
sorry about the merge conflict here, I merged in the wrong order. fixing... |
Fixes the issue of the text input/clear control still being keyboard focusable when not active/visible.
Having "go to..." announced as part of a link is completely unnecessary, verbose, redundant for AT users. They know that a link "goes to" something. For the `target=_blank` links, best to front-load what they link to.
|
Hey @patrickhlauke, TravisCI finished with status |
miketaylr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2487 and #2488
Issue #2487 - remove/tweak the
aria-labels in footer linksIssue #2488 - change between
visibility:hidden/visibility:visiblefor the search form, which also makes the form non-focusable and hidden from assistive technologies when it's not activer? @miketaylr