Fixes #2590 - Fixes the link in docs/tests.md#2591
Merged
miketaylr merged 1 commit intowebcompat:masterfrom Sep 24, 2018
Merged
Fixes #2590 - Fixes the link in docs/tests.md#2591miketaylr merged 1 commit intowebcompat:masterfrom
miketaylr merged 1 commit intowebcompat:masterfrom
Conversation
miketaylr
requested changes
Sep 24, 2018
Member
miketaylr
left a comment
miketaylr
left a comment
There was a problem hiding this comment.
Thank you @kritisingh1!
The changes look good, but please follow the commit conventions we use in the project.
(step 9: https://github.com/webcompat/webcompat.com/blob/master/docs/pr-coding-guidelines.md)
kritisingh1
force-pushed
the
fix-link
branch
from
de8d5db to
9552e2f
Compare
Contributor
Author
|
@miketaylr done. I'll take care of it from next time. Please review. Thanks! |
kritisingh1
changed the title
Member
|
Perfect, thanks! |
miketaylr
approved these changes
Sep 24, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #2590
@zoepage please review