Fixes #2563 - Fixes status change instructions#2598
Merged
laghee merged 1 commit intowebcompat:masterfrom Sep 25, 2018
Merged
Conversation
Travis tests have failedHey @hritvi, 1st Buildnosetestsnpm run test:js -- --reporters="runner" --firefoxBinary=`which firefox`TravisBuddy Request Identifier: 6370bdf0-c0a5-11e8-baa7-8ff80113b6c0 |
laghee
approved these changes
Sep 25, 2018
Contributor
laghee
left a comment
There was a problem hiding this comment.
Thanks, @hritvi! This looks great. Do remember next time to change the PR title to start with "Fixes" (not just the commit message) so it closes out the issue automatically, though. (I changed it for you here.)
(see step 9: https://github.com/webcompat/webcompat.com/blob/master/docs/pr-coding-guidelines.md)
Contributor
|
@miketaylr Had to kick Travis -- looks like it was just the milestone thing. It actually looks like it's letting me merge... So I'm going to try it! :sad_there's_no_power_glove_in_github_emojis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #2563
r? @laghee