Fixes #1822 - Adds GitHub contact form for anonymous reporting#2744
Merged
miketaylr merged 4 commits intowebcompat:masterfrom Dec 18, 2018
Merged
Fixes #1822 - Adds GitHub contact form for anonymous reporting#2744miketaylr merged 4 commits intowebcompat:masterfrom
miketaylr merged 4 commits intowebcompat:masterfrom
Conversation
These tests make sure that the syntax checking for the GitHub contact name follows the right format. An error message should be displayed if not valid. Also the empty string should be ok.
This checks that the format of the GitHub contact name is correct
Member
Author
|
Let's see if CircleCI is happier. |
Member
Author
|
Alleluiah! All checks have passed! @miketaylr |
miketaylr
reviewed
Dec 18, 2018
| /* Check to see if the GitHub username has the right syntax. */ | ||
| this.checkGitHubUsername = function() { | ||
| var contact = this.contactField.val(); | ||
| if (this.isValidGitHubUsername(contact) || $.trim(contact) === "") { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #1822
Proposed PR background
We identified that some people have a github username but don't want the too hungry webcompat.com to be allowed for permissions. This is a very low tech, soft way to give an opportunity for people to share their GitHub nickname.
This will hopefully work better than the previous pull request #2713
r? @miketaylr