Fixes #2771 - Removes unnecessary favicons#2804
Conversation
da5b6d6 to
fb644cc
Compare
|
I want to be sure we're doing this for a principled reason and not just because there's a lot of them. @marimeireles do we have measurements of the before/after to justify deleting them, I guess in Safari since that's the browser with the bug? |
|
That said, I do agree that we're maintaining a lot of images just for the possibility that someone bookmarks the site on their phone or ipad or whatever, and wants a pretty icon. |
No, but I can do it. I'll post my results in the issue #2771, better than here, right? |
|
@marimeireles can we do a little bit of research and find the minimal viable set of favicon images required to not look like crap on regular and hi-dpi monitors? I'm inclined to suggest we just burn it all down and revisit app icons once we add some app-like functionality (via service workers, or anything compelling that would inspire you to save the site to your home screen) |
I thought we already had the functionality. |
fb644cc to
d0c58b8
Compare
No, we just have an app manifest. No service workers. |
d0c58b8 to
661f953
Compare
|
no issue for me. |
miketaylr
left a comment
There was a problem hiding this comment.
Cool, let's go for it. We can always change back if we decide it's important in the future.
Removed a few favicons that weren't necessary and were being downloaded when user was on Safari.
r? @miketaylr