Skip to content

Fixes #1838 - Separates the python dependencies into prod and dev #2834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karlcow merged 4 commits into from
Apr 4, 2019
Merged

Fixes #1838 - Separates the python dependencies into prod and dev #2834

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
06569de
Issue #1838 - Adjusts python dependencies config
karlcow Apr 4, 2019
54d485a
Issue #1838 - Adjusts the documentation for new py dependencies
karlcow Apr 4, 2019
96931da
Issue #1838 - Adjusts package.json which is used by circleci
karlcow Apr 4, 2019
e773656
Merge branch 'master' into 1838/1
karlcow Apr 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Issue #1838 - Adjusts the documentation for new py dependencies
  • Loading branch information
@karlcow
karlcow committed Apr 4, 2019
commit 54d485a5ab9cf0c07d900269b7dabec0fcde1cd9
4 changes: 2 additions & 2 deletions docs/dev-env-setup.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,8 @@ source env/bin/activate
# Windows: http://pillow.readthedocs.org/en/3.0.x/installation.html#windows-installation
# Linux: http://pillow.readthedocs.org/en/3.0.x/installation.html#linux-installation
# install rest of dependencies
pip2 install -r config/requirements.txt
# In Ubuntu: if ImportError: No module named flask.ext.github occurs, it means the dependencies in requirements.txt are installed in /usr/lib instead of <project_repository>/env/python<version>/site-packages.
pip2 install -r config/requirements-dev.txt
# In Ubuntu: if ImportError: No module named flask.ext.github occurs, it means the dependencies in requirements-dev.txt are installed in /usr/lib instead of <project_repository>/env/python<version>/site-packages.
# In this case, use virtual environment's pip from <project_repository>/env/lib/pip folder of the project repository instead of the global pip.
```

Expand Down
2 changes: 1 addition & 1 deletion run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
==============================================
It seems like you don't have all dependencies.
Please re-run:
pip install -r config/requirements.txt
pip install -r config/requirements-dev.txt
==============================================
'''

Expand Down