Fixes #3063 - Move search bar handling into shared navbar.js#3064
Merged
Fixes #3063 - Move search bar handling into shared navbar.js#3064
Conversation
added 3 commits
October 28, 2019 16:11
The only thing it is doing at this point is handling the searchbar. There's some old code in there adding a class to indicate touch vs no-touch, but it's dead code. For the history, it was added here: 51c16a4
miketaylr
commented
Oct 28, 2019
| var searchBarClose = $(".js-SearchBarClose"); | ||
|
|
||
| this.init = function() { | ||
| var htmlClass = |
Member
Author
There was a problem hiding this comment.
I dug into the history, and this is unused (has been for a few years).
Member
Author
|
r? @karlcow No new code here, just moving things around. But adding some new tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And add some missing tests.