Fixes #3071 - Change page title based on form#3074
Merged
Conversation
miketaylr
changed the title
Member
|
@bacharakis you have a failing test now :). want to tackle it? otherwise, i can push a fix at some point today to this PR. |
Contributor
Author
|
@miketaylr Sure thing! |
miketaylr
force-pushed
the
update-title
branch
from
04e7764 to
ca16d3d
Compare
Member
It was a simple whitespace fix, I just pushed a change. |
miketaylr
approved these changes
Nov 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #3071
Please provide enough information so that others can review your pull request:
Changing the page title based on the form served will help GA track page visits and duration