Fixes #3132 - Control anonymous reporting via config option#3133
Merged
Fixes #3132 - Control anonymous reporting via config option#3133
Conversation
added 3 commits
January 6, 2020 13:29
…reports If not set to something truthy, return a 400
miketaylr
commented
Jan 6, 2020
| OAUTH_TOKEN = os.environ.get('OAUTH_TOKEN') | ||
| SECRET_KEY = os.environ.get('SECRET_KEY') or 'NO SECRETS' | ||
| HOOK_SECRET_KEY = os.environ.get('HOOK_SECRET_KEY') or 'SECRETS' | ||
| ANON_REPORTING_ENABLED = False |
Member
Author
There was a problem hiding this comment.
Maybe in the future we want to allow localhost anonymous reporting, but for now just set everything to False.
miketaylr
commented
Jan 6, 2020
karlcow
approved these changes
Jan 9, 2020
Member
karlcow
left a comment
karlcow
left a comment
There was a problem hiding this comment.
Everything looks good. Thanks.
| UPLOADS_DEFAULT_DEST = os.environ.get('PROD_UPLOADS_DEFAULT_DEST') | ||
| UPLOADS_DEFAULT_URL = os.environ.get('PROD_UPLOADS_DEFAULT_URL') | ||
| ANON_REPORTING_ENABLED = os.environ.get('PROD_ANON_REPORTING_ENABLED') | ||
|
|
Member
There was a problem hiding this comment.
What is happening if the value is not defined in environment?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @karlcow