Skip to content

Issue #3178 - Adds public_url for action: closed#3182

Merged
miketaylr merged 1 commit intowebcompat:masterfrom
karlcow:3178/1
Feb 6, 2020
Merged

Issue #3178 - Adds public_url for action: closed#3182
miketaylr merged 1 commit intowebcompat:masterfrom
karlcow:3178/1

Conversation

@karlcow
Copy link
Copy Markdown
Member

@karlcow karlcow commented Feb 6, 2020

This PR fixes issue #3178

Proposed PR background

we are now making sure the public_url is present in the data we receive.

@karlcow karlcow requested review from ksy36 and miketaylr February 6, 2020 08:16
@karlcow
Copy link
Copy Markdown
Member Author

karlcow commented Feb 6, 2020

ok @miketaylr @ksy36 here we are. Thanks for spotting it and opening the issue.

Copy link
Copy Markdown
Member

@miketaylr miketaylr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@miketaylr miketaylr merged commit a69492d into webcompat:master Feb 6, 2020
@karlcow karlcow deleted the 3178/1 branch August 24, 2020 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants