Fixes #3351 - Moves the analytics comment

[bijjybox]

Fixes - #3351

[karlcow]

@apsychogirl you might want to adjust the PR, to just modify what needs to be modified. I have the feeling you got a formater which changed everything in the initial code.

[ksy36]

Thanks for looking into this @apsychogirl . Looks good to me, though you might want to check Karl's comment

[karlcow]

so a couple of things…

1. The title of the PR needs to be Fixes #3351 - Moves the analytics comment.
2. The issue #3351 doesn't talk about removing the comment. It says move the comment two lines up.
3. The commit messages need to have the proper format referencing the issue number. for example, git commit -m 'issue #3351 - moves the Google Analytics comment' webcompat/templates/layout.html

Could you fix this.

[karlcow]

@apsychogirl yes! that's it. one last thing.

Could you do

git rebase -i HEAD~3

1. replace pick by f in front of the last two lines
2. changes the message of the first line by issue #3351 - moves the Google Analytics comment after the pick and the sha1

Then

git push -f origin 3351/1

Thanks.

[bijjybox]

Just a doubt, if I change the message of the first line, won't that merge the commit with issue #3354 ?
This is the output of -
git rebase -i HEAD~3

[karlcow]

hmmm not the right git rebase. Yup DO NOT DO that :)

[karlcow]

@apsychogirl could you tell me what

git log --oneline

returns for the first 5 lines.

[bijjybox]

dfc27405 (HEAD -> 3351/1) Removed the google analytics comment
b9ba8a96 Issue #3354 - fixes syntax
3f8d764d Issue #3354 - complete the template tests
5c1d1a8a issue #3354 - convert fully to pytest
5e5b7d6b Issue #3354 - Handles FileNotFoundError for assets

[karlcow]

@apsychogirl I'm confused.

dfc27405 (HEAD -> 3351/1) Removed the google analytics comment

but your latest commit says:

2dcdf7a Fixes #3351 - moves the Google Analytics comment 

oh wait… you are not committing into your branch.

[karlcow]

ah no that's not it. Sorry about that.
How come the local log doesn't reflect the latest two commits?

[karlcow]

@apsychogirl you should see these 3 commits
https://github.com/apsychogirl/webcompat.com/commits/3351/1

[karlcow]

@apsychogirl do you want to try to fix it? or do you want me to fix your pull request?

[bijjybox]

I'll try to find the error and will let you know

[bijjybox]

@karlcow , does this seems fine?

[karlcow]

Thanks a lot @apsychogirl
congratulations on making the PR square!