Skip to content

Issue #3316 - fixed misaligned check-marks#3363

Merged
ksy36 merged 1 commit intomasterfrom
issues/3316
Jun 29, 2020
Merged

Issue #3316 - fixed misaligned check-marks#3363
ksy36 merged 1 commit intomasterfrom
issues/3316

Conversation

@magsout
Copy link
Copy Markdown
Member

@magsout magsout commented Jun 26, 2020

This PR fixes issue #3316

see sample https://share.getcloudapp.com/ApuAxkWO

@magsout magsout requested review from karlcow and ksy36 June 26, 2020 21:07
@magsout
Copy link
Copy Markdown
Member Author

magsout commented Jun 26, 2020

I added a wrapper around the input to have a constant height. We can add checkmarks in the center using absolute and a transform.

@karlcow
Copy link
Copy Markdown
Member

karlcow commented Jun 28, 2020

I let @ksy36 review the JS part.
Thanks a lot @magsout

Copy link
Copy Markdown
Contributor

@ksy36 ksy36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this @magsout

@ksy36 ksy36 merged commit abea7ce into master Jun 29, 2020
@ksy36 ksy36 deleted the issues/3316 branch June 29, 2020 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants