Fixes #3380 - Makes Wizard Form the default (python)#3384
Merged
miketaylr merged 4 commits intowebcompat:masterfrom Jul 15, 2020
Merged
Fixes #3380 - Makes Wizard Form the default (python)#3384miketaylr merged 4 commits intowebcompat:masterfrom
miketaylr merged 4 commits intowebcompat:masterfrom
Conversation
These are breadcrumbs of dead code and useless redirection of variables. Let's remove them before modifying the Form.
This optimizes a bit the code to make it easier to read. It doesn't change the global logic
3 tasks
miketaylr
requested changes
Jul 14, 2020
ksy36
approved these changes
Jul 14, 2020
Originally the list of tuples were 2 items long. but the wizard is using in some cases 3 items long list (because of icons) for radio fields. This leds to the duplication of the list of problem_choices with 2 items and 3 items. So instead of duplicating code, let's handle it in the function itself. There might be something more elegant to do. We can discover that later.
So this is doing a couple of things. - It removes the duplicate problem_choices list of 2 items tuples. - it removes the IssueForm class - it transfers the IssueForm attributes into FormWizard - it reorders in some broad categories the fields for the form - it switches getform to FormWizard. (it was not the case!) - it adjusts the tests
Member
|
(we should be sure to test carefully on staging here, just to make sure we don't break reporting :)) |
Member
Author
Definitely. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #3380
Proposed PR background