Fixes #3445 - Add 2 more moderation milestones#3452
Merged
Conversation
miketaylr
force-pushed
the
issues/3445/1
branch
from
d4d13cd to
ebded10
Compare
miketaylr
commented
Aug 17, 2020
added 3 commits
August 17, 2020 20:12
miketaylr
force-pushed
the
issues/3445/1
branch
from
2af0b1b to
80d6007
Compare
Member
Author
|
r? @karlcow (No rush on review, any time this week is great, thanks!) |
Member
|
next two days: diagnostics. Review on Thursday. |
karlcow
approved these changes
Aug 21, 2020
Member
karlcow
left a comment
karlcow
left a comment
There was a problem hiding this comment.
👏
webcompat/webhooks/__init__.py 19 0 100%
webcompat/webhooks/helpers.py 138 5 96% 108, 171-175
webcompat/webhooks/model.py 149 0 100%
- 108 is not related to your PR.
- 171-175 is
def make_request(method, path, payload_request):but not worth testing IMHO.
Thanks @miketaylr beautiful code.
| return payload_request | ||
|
|
||
|
|
||
| def prepare_invalid_issue(title=None): |
Member
There was a problem hiding this comment.
🤔 all these prepare_BLAH_issue, I wonder if it's a case of `prepare_issue('BLAH')
Member
Author
There was a problem hiding this comment.
Hm, I think you're right. Wouldn't be too much work. I'll circle back and file a follow-up for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OK, this is ready for review. We can test it on staging at any point -- I've created the milestones in the webcompat-tests-private repo. But before we deploy to production, we need to add the milestones to web-bugs-private.