Skip to content

fix #3528 - Fix CSS for description textarea#3534

Closed
karlcow wants to merge 1 commit intowebcompat:masterfrom
karlcow:3528/1
Closed

fix #3528 - Fix CSS for description textarea#3534
karlcow wants to merge 1 commit intowebcompat:masterfrom
karlcow:3528/1

Conversation

@karlcow
Copy link
Copy Markdown
Member

@karlcow karlcow commented Feb 10, 2021

This PR fixes issue #3528

Proposed PR background

This is fixing an issue with the CSS in the textarea where the green progress bar was hiding the rest of the text.

@karlcow karlcow requested a review from magsout February 10, 2021 00:46
@karlcow karlcow linked an issue Feb 10, 2021 that may be closed by this pull request
@emilio
Copy link
Copy Markdown
Contributor

emilio commented Feb 10, 2021

That doesn't work on Gecko does it? Because of padding-block-end shenanigans.

@emilio
Copy link
Copy Markdown
Contributor

emilio commented Feb 10, 2021

Why not just changing .progress-textarea .progress to position: relative? That seems to fix this and as a bonus it doesn't overlap the scrollbars, etc.

@emilio
Copy link
Copy Markdown
Contributor

emilio commented Feb 10, 2021

content: ""; in that rule is useless btw, and likely to break stuff once browsers implement css-content as per spec.

@karlcow
Copy link
Copy Markdown
Member Author

karlcow commented Feb 10, 2021

That doesn't work on Gecko does it? Because of padding-block-end shenanigans.

It worked on my local build. so that is strange it didn't work for you?

But yes the full thing would benefit of simpler CSS. I don't like very much the way it's done.

@karlcow
Copy link
Copy Markdown
Member Author

karlcow commented Feb 10, 2021

Ah long line! gotcha! indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Textarea progress bar hides text when typing

3 participants