Skip to content

Fixes #3769 - Dual form reporter#3771

Merged
ksy36 merged 2 commits into
mainfrom
issue/3769/1
Jul 4, 2023
Merged

Fixes #3769 - Dual form reporter#3771
ksy36 merged 2 commits into
mainfrom
issue/3769/1

Conversation

@ksy36

@ksy36 ksy36 commented Jun 20, 2023

Copy link
Copy Markdown
Contributor

In this PR I've added the following:

  • Dual flow for the reporter
  • Reports are saved to BQ for both short and detailed reports

@ksy36 ksy36 force-pushed the issue/3769/1 branch 2 times, most recently from c363a18 to ac0a2ba Compare June 20, 2023 23:22
@ksy36 ksy36 marked this pull request as ready for review June 21, 2023 00:08
@ksy36 ksy36 requested a review from skyschub June 21, 2023 00:08
@ksy36

ksy36 commented Jun 21, 2023

Copy link
Copy Markdown
Contributor Author

r? @denschub

@skyschub skyschub left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My Python skills aren't the strongest, but this looks reasonable - and it works. r+ :)

@ksy36

ksy36 commented Jul 4, 2023

Copy link
Copy Markdown
Contributor Author

Thanks!

@ksy36 ksy36 merged commit 6491b1d into main Jul 4, 2023
@ksy36 ksy36 deleted the issue/3769/1 branch July 4, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants