Merged
Conversation
miketaylr
pushed a commit
that referenced
this pull request
Nov 17, 2014
Member
|
@magsout your changes look good. r+. I pushed a commit so clicking on the labels will update the search. Can you review then merge if it's OK? |
miketaylr
force-pushed
the
Labels-component
branch
from
e0f937d to
b19173d
Compare
Member
Author
|
@miketaylr thanks, but there is not android label, we need to remove it |
Member
|
@magsout nah, there's one on the real repo: https://github.com/webcompat/web-bugs/labels Will add to the test repo as well. |
Member
|
Added to test repo. Should be OK to merge. 👍 |
Member
Author
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made a label component on the idea of issue #402 , so if it is not possible, the border does not appear and we can merge anyway.
r? @miketaylr