Conversation
BIG THXXXXXXXXXXXXXXXXXXX to @vladikoff
Member
Author
|
(fixed commit, it was referencing the wrong commit) |
Member
Author
Member
|
r+ on this mike :) |
Member
|
r+ 👍 |
magsout
added a commit
that referenced
this pull request
Nov 21, 2014
Issue #272 - Fix SOP violation in tests (session cookies will now work)
Member
Author
|
woohoo, thanks. |
miketaylr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BIG THXXXXXXXXXXXXXXXXXXX to @vladikoff
Note, Travis will probably fail because now that logging in is "sticky", the tests counting the number of browse categories will include "Issues reported by Me". So this fix revealed a flaw in our testing.
Will provide a fix for that issue tonight or tomorrow then ask for review (so we don't have to accept a pull which breaks the build on master).