Accessibility Fixes Round 2

[andrewmcgivery]

Remainder (Hopefully) of Accessibility fixes.

Closes: #464

[miketaylr]

Hmm, TOTAL: tested 1 platforms, 24/24 tests failed. That seems a little crazy, will need to investigate.

[andrewmcgivery]

Could it have something to do with the error message at the bottom of the build output?

The command "node_modules/.bin/intern-runner config=tests/functional/intern user="$USER" pw="$PW"" exited with 1.

[miketaylr]

Yeah, the exist code 1 just means it didn't pass (which would be exit 0). It may have just been a hiccup, the other day GitHub was slow and I had some test failures. I'll pull locally and check it out.

[andrewmcgivery]

Alright well if I screwed something up, please let me know!

[miketaylr]

@andrewmcgivery one thing, can you fix the commit message? Something like:

Issue #464 - Accessibility Fixes Round 2.

That way it will create a link between the commit and the issue. You should be able to do git commit --amend and tweak it, then git push -f.

[miketaylr]

FWIW, all tests pass for me locally. So r+ with the ammended commit message. 🍰

[andrewmcgivery]

Better?

[miketaylr]

Looks good. 👍

Also, I just remembered why the build is failing: the $USER, $PW, $ISSUES_REPO_URI, and $BOT_OAUTH_TOKEN environment variables (which contain a bot's github credentials) aren't exposed to pull requests from forks (more info here) . Kinda crappy, but not the end of the world.

[miketaylr]

Will probably cut a release and deploy to production tomorrow at some point. Thx again for the PR @andrewmcgivery! 🙇

[andrewmcgivery]

Just to confirm, did I do anything wrong?

And awesome! Can't wait to see these live! :) Thanks!

[miketaylr]

Nope, nothing wrong. ^_^ You can see all tests passing after I merged in your patches: https://travis-ci.org/webcompat/webcompat.com/builds/43674983

[andrewmcgivery]

Good to know!

[magsout]

👍 again , good job @andrewmcgivery

[andrewmcgivery]

Thanks! :)

[miketaylr]

Just deployed to production.

[andrewmcgivery]

Awesome!