Skip to content

Fixes #399 and #516 - Keep issues model and URL params in sync #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miketaylr merged 8 commits into from
Jan 29, 2015
Merged

Fixes #399 and #516 - Keep issues model and URL params in sync #542

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
06e8f88
Issue #399 - Read params from the URL and sync with model
Jan 6, 2015
f0d8f87
Issue #399 - Add state=open to default params
Jan 21, 2015
c7e0c19
Issue #516 - Call loadIssues on history navigation
Jan 21, 2015
0c9ce8a
Issue #399 - Keep page param in sync with pagination.
Jan 21, 2015
ea6a14e
Issue #399 - Only remove state param intersection if we have one in t…
Jan 21, 2015
ae22e34
Issue #399 - Tests for reading from URL and history navigation
Jan 21, 2015
3005d01
Issue #399 - Use a stage parameter for the filters
Jan 22, 2015
cdeda2c
Issue #399 - Add tests for stage param manipulation
Jan 22, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Issue #516 - Call loadIssues on history navigation
  • Loading branch information
Mike Taylor committed Jan 21, 2015
commit c7e0c1923e1348a726b88585806b0088c55415c3
3 changes: 1 addition & 2 deletions webcompat/static/js/lib/issue-list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,7 @@ issueList.IssueView = Backbone.View.extend({
issueList.events.on('paginate:next', _.bind(this.requestNextPage, this));
issueList.events.on('paginate:previous', _.bind(this.requestPreviousPage, this));
wcEvents.on('dropdown:change', _.bind(this.updateModelParams, this));
window.addEventListener('popstate', _.bind(this.loadIssues, this));

this.loadIssues();
},
Expand All @@ -324,7 +325,6 @@ issueList.IssueView = Backbone.View.extend({
// Attemps to load model state from URL params, if present,
// otherwise grab model defaults and load issues

// popstate should load this method.
var category;
// get params excluding the leading ?
var urlParams = location.search.slice(1);
Expand Down Expand Up @@ -468,7 +468,6 @@ issueList.IssueView = Backbone.View.extend({
this.fetchAndRenderIssues();
},
updateModelParams: function(params, options) {
// TODO: profile how many times this gets called and optimize.
// convert params string to an array,
// splitting on & in case of multiple params
// params are merged into issues model
Expand Down