Fixes #687 - Add ability to upload images in comments for an issue

[miketaylr]

r? @karlcow for Python bits
r? @magsout for CSS + JS

[miketaylr]

(I still need to fix the flaky tests, the failures are unrelated).

[karlcow]

@miketaylr r+ for the python part. Tested. Code is working. I have a curiosity question up there, but that's just for curiosity.

[magsout]

hum need help I think @miketaylr

When I try to log in (localhost)

Something went wrong trying to sign into GitHub. :(

[karlcow]

@magsout try to erase session.db first. Then restart

[magsout]

@karlcow same error :(

[miketaylr]

Bummer @magsout. Two debug requests:

1. Can you paste the HTTP logs (from the terminal) starting just before you click "Log in"? Linking a gist will be fine.
2. Can you open the network panel of devtools and see if there are any 500 errors or something?

[magsout]

@miketaylr

[magsout]

https://gist.github.com/magsout/9d5c90783c23ae58895c

[karlcow]

@magsout you seem to have logged in ?
Did you log out of github too? Not only webcompat.

[magsout]

you seem to have logged in ?

@karlcow yes but no. I'm not logged

Did you log out of github too? Not only webcompat.

I'm logged on Github. I tried to logged out and logged in...

[miketaylr]

Man, webapps are hard. @magsout, I don't recall if I shared the id and secret for the local testing app (that's what will correspond to the part from config.py below) with you or not. I just reset all user tokens there, but if you made your own can you try to "Revoke all users tokens"?

# We're running on localhost, use the test application
    GITHUB_CLIENT_ID = os.environ.get('FAKE_ID') or "<secrets!>"
    GITHUB_CLIENT_SECRET = os.environ.get('FAKE_SECRET') or "<secrets!>"
    GITHUB_CALLBACK_URL = "http://localhost:5000/callback"

[miketaylr]

And after doing that, rm Session.db and then try to restart the app and login.

[magsout]

I don't recall if I shared the id and secret for the local testing app

Heu no, I sent to you my config by email.

just reset all user tokens there, but if you made your own can you try to "Revoke all users tokens"?

Done, and still same error :(

[magsout]

@miketaylr

Except my comment LGTM r+

[miketaylr]

Thanks for the review @magsout! Will make those changes (and spend some time looking at the issue that @karlcow raised).

[miketaylr]

But I was wondering why the double dance dict -> json -> dict

You're awesome @karlcow. 🎈

That's just a mistake on my part, I forgot that raw_request returns a Requests Response object, not a Flask one. So I was just doing extra work for no good reason. Will fix.