Conversation
|
cooool. Good job @miketaylr
I don't like a linter modifies files, I think it's better to display an error or warning. |
That's fair. By default it only displays errors. But if you have 10,000,000,000 whitespace errors, you have the option of manually using that |
|
OK cool, tests are passing (we had some weird timeout thing). Let's pull it in. |
|
Ooops haha. |
Fixes #813. Replace JSHint with ESLint
Sounds good. Good job 👍 |
This add the equivalent linting rules we had before plus a handful of style checks, mostly around whitespace.
Running
gruntwill still run the eslint task, or you can rungrunt eslintfor only that.One cool thing is you can tell it to "fix" the errors for you (for certain simple ones, like whitespace or indentation):
eslint webcompat/static/js/lib/user-activity.js --fix, for example.r? @magsout