Skip to content

Fixes #813. Replace JSHint with ESLint#817

Merged
miketaylr merged 10 commits intomasterfrom
issues/813/1
Nov 5, 2015
Merged

Fixes #813. Replace JSHint with ESLint#817
miketaylr merged 10 commits intomasterfrom
issues/813/1

Conversation

@miketaylr
Copy link
Copy Markdown
Member

This add the equivalent linting rules we had before plus a handful of style checks, mostly around whitespace.

Running grunt will still run the eslint task, or you can run grunt eslint for only that.

One cool thing is you can tell it to "fix" the errors for you (for certain simple ones, like whitespace or indentation):

eslint webcompat/static/js/lib/user-activity.js --fix, for example.

r? @magsout

@magsout
Copy link
Copy Markdown
Member

magsout commented Nov 4, 2015

cooool. Good job @miketaylr

One cool thing is you can tell it to "fix" the errors for you (for certain simple ones, like whitespace or indentation):

I don't like a linter modifies files, I think it's better to display an error or warning.

@miketaylr
Copy link
Copy Markdown
Member Author

I don't like a linter modifies files, I think it's better to display an error or warning.

That's fair. By default it only displays errors. But if you have 10,000,000,000 whitespace errors, you have the option of manually using that --fix option. 😄

@miketaylr
Copy link
Copy Markdown
Member Author

OK cool, tests are passing (we had some weird timeout thing). Let's pull it in.

@miketaylr
Copy link
Copy Markdown
Member Author

Ooops haha.

@miketaylr miketaylr reopened this Nov 5, 2015
miketaylr pushed a commit that referenced this pull request Nov 5, 2015
Fixes #813. Replace JSHint with ESLint
@miketaylr miketaylr merged commit 01385a5 into master Nov 5, 2015
@miketaylr miketaylr deleted the issues/813/1 branch November 5, 2015 02:46
@magsout
Copy link
Copy Markdown
Member

magsout commented Nov 5, 2015

That's fair. By default it only displays errors. But if you have 10,000,000,000 whitespace errors, you have the option of manually using that --fix option. 😄

Sounds good. Good job 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants