Skip to content

Issue #855 - Layout broken on contributors page#888

Merged
miketaylr merged 2 commits intomasterfrom
contributors-page
Dec 30, 2015
Merged

Issue #855 - Layout broken on contributors page#888
miketaylr merged 2 commits intomasterfrom
contributors-page

Conversation

@magsout
Copy link
Copy Markdown
Member

@magsout magsout commented Dec 29, 2015

Close #855

r? @miketaylr

@miketaylr
Copy link
Copy Markdown
Member

Seems like the tests that are failing are related to the contributors page:

FAIL: main - Contributors - clicking first section closes it (10563ms)

Maybe we need to add js-blah classes so we don't break them in the future. Will take a look in a bit.

@magsout
Copy link
Copy Markdown
Member Author

magsout commented Dec 29, 2015

let me fixe this

@miketaylr
Copy link
Copy Markdown
Member

💯

@magsout
Copy link
Copy Markdown
Member Author

magsout commented Dec 30, 2015

OK, fixed 👍

@miketaylr
Copy link
Copy Markdown
Member

Woohoo!

miketaylr pushed a commit that referenced this pull request Dec 30, 2015
Issue #855 - Layout broken on contributors page
@miketaylr miketaylr merged commit 878036b into master Dec 30, 2015
@miketaylr miketaylr deleted the contributors-page branch December 30, 2015 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants