(feat): support universal arch for Darwin
#575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goosewobbler
force-pushed
the
sm/support-darwin-universal-arch
branch
from
e5bd287 to
bc3291e
Compare
goosewobbler
force-pushed
the
sm/support-darwin-universal-arch
branch
from
dfab096 to
7760cfa
Compare
goosewobbler
force-pushed
the
sm/support-darwin-universal-arch
branch
from
7760cfa to
f6c2ad7
Compare
goosewobbler
force-pushed
the
sm/support-darwin-universal-arch
branch
4 times, most recently
from
fe1ea22 to
a8ebb1f
Compare
goosewobbler
force-pushed
the
sm/support-darwin-universal-arch
branch
from
a8ebb1f to
5aeafda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we are using the Node
process.archvalue to generate the binary path, this doesn't align to the arch values which can be used by Forge and EB.Getting the arch value from the respective build tool config files was considered, but both tools allow setting these values as CLI args (and Forge doesn't have a config option for arch anyway), so a more robust way of handling it is to generate paths for each supported arch and check each one for existence and executability. This is implemented for all platforms when using Forge and on Darwin when using
electron-builder.Also added: support for Forge custom output directories (since electron/forge#3458 was merged).
Closes #565.
TODO:
allOfficialArchsForPlatformAndVersion