Skip to content

feat: update mqttClient.min.js and refactor index.html #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 6, 2022
Merged

feat: update mqttClient.min.js and refactor index.html #3

merged 2 commits into from
Sep 6, 2022

Conversation

@shengyuan
Copy link
Member

@shengyuan shengyuan commented Sep 5, 2022

說明

  1. 調整 mqttClient.min.js，進行 mqtt server 的調整。
  2. 刪除部份追蹤及 SEO 的程式。

@shengyuan shengyuan requested a review from Yu040419 September 5, 2022 10:11
@shengyuan shengyuan self-assigned this Sep 5, 2022
Yu040419
Yu040419 reviewed Sep 6, 2022
View reviewed changes
Copy link

@Yu040419 Yu040419 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

這邊也是，要不要像 Bit 一樣，在根目錄的 README.md 裡面寫說，這邊的源碼在哪裡呢～？

@shengyuan
Copy link
Member Author

shengyuan commented Sep 6, 2022 •
edited
Loading

這邊也是，要不要像 Bit 一樣，在根目錄的 README.md 裡面寫說，這邊的源碼在哪裡呢～？

這裡的 mqttClient.js 與平台的有些不同，另記錄在票中，也更新到 readme 裡。

@Yu040419 Yu040419 merged commit 06187ff into master Sep 6, 2022
@Yu040419 Yu040419 deleted the feature/5720 branch September 6, 2022 02:30
shengyuan added a commit that referenced this pull request Sep 13, 2022
@shengyuan
Revert "Merge pull request #3 from webduinoio/feature/5720"
39d2fc0 
This reverts commit 06187ff, reversing
changes made to 14afa24.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Yu040419 Yu040419 Yu040419 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@shengyuan shengyuan

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shengyuan @Yu040419