Change the identify file path from hardcoded absolute to user based #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Issue The issue is that a hardcoded full path is in a github action something like `/home/runner` if you need that file inside of a docker build system you can not simply mount that file into the container. You need to copy the file, sed it (string replace) and then mount it. If we would use something like a "home dir" placeholder this would work out of the box. Not sure if ~ works in all cases but %d should. https://linux.die.net/man/5/ssh_config
julianhille
commented
Sep 19, 2025
| @@ -66,7 +66,7 @@ try { | |||
|
|
|||
| const sshConfig = `\nHost key-${sha256}.github.amrom.workers.dev\n` | |||
| + ` HostName github.com\n` | |||
| + ` IdentityFile ${homeSsh}/key-${sha256}\n` | |||
| + ` IdentityFile ~/.ssh/key-${sha256}\n` | |||
There was a problem hiding this comment.
Suggested change
| + ` IdentityFile ~/.ssh/key-${sha256}\n` | |
| + ` IdentityFile %d/.ssh/key-${sha256}\n` |
this might/should also work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The issue is that a hardcoded full path of the identity file inside of the ssh config is in case of a github action run something like
/home/runner.If you need that file inside of a docker build system you can not simply mount that file into the container. You need to copy the file, sed it (string replace) and then mount it.
If we would use something like a "home dir" placeholder this would work out of the box.
Not sure if ~ works in all cases but %d should.
https://linux.die.net/man/5/ssh_config