feat(processPattern): add support for `{RegExp)` matches (`pattern.test`) #235

hybrist · 2018-03-01T18:22:18Z

We want to match some of our existing asset logic which generates image file names from the source paths. Having a function that generates those paths seemed like the simplest solution.

This mirrors the way the file-loader works, allowing to reuse logic. https://github.com/webpack-contrib/file-loader#regexp

jsf-clabot · 2018-03-01T18:22:20Z

All committers have signed the CLA.

hybrist · 2018-03-01T18:58:12Z

Actually, trying to make sure that templates are supported in the returned value.

michael-ciniawsky

I'm in favor renaming pattern.toRegExp => pattern.test instead

michael-ciniawsky · 2018-03-01T21:35:03Z

README.md

      from: 'src/'
      to: 'dest/[name].[hash].[ext]',
      toType: 'template'
+      // Optional: provide a regExp to extract additional placeholders


Please make a new 'section' for this option, or does it only work with toType: 'template' ?

Also needs to be added to options table please

It will only work with the template toType. Will update the table.

hybrist · 2018-03-01T21:54:40Z

Would it make sense to use pattern.regExp instead of pattern.test? That's consistent with how file-loader exposes this feature. Happy to switch to either. :)

hybrist · 2018-03-01T22:12:23Z

Added to options table
Renamed to options.test
Added dedicated section for options.test to the README containing the same docs that also appear in the file-loader README for options.regExp

alexander-akait · 2018-03-01T22:13:35Z

@jkrems rebase 👍

michael-ciniawsky

👍

hybrist · 2018-03-01T22:17:03Z

Rebase'd.

michael-ciniawsky

Only minor important nitpicks, please rebase :)

michael-ciniawsky · 2018-03-01T22:17:44Z

README.md


+### `test`
+
+Defines a regExp to match some parts of the file path.


regExp => {RegExp}

michael-ciniawsky · 2018-03-01T22:18:40Z

README.md

+
+Defines a regExp to match some parts of the file path.
+These capture groups can be reused in the name property using `[N]` placeholder.
+Note that `[0]` will be replaced by the entire tested string,


> ℹ️ Note

string => {String}

Went with "entire relative path of the file" while I was touching it since that seemed easier to understand than what the "tested string" was.

michael-ciniawsky · 2018-03-01T22:19:02Z

README.md

+Defines a regExp to match some parts of the file path.
+These capture groups can be reused in the name property using `[N]` placeholder.
+Note that `[0]` will be replaced by the entire tested string,
+whereas `[1]` will contain the first capturing parenthesis of your regex


regex => {RegExp}

…st`)

hybrist · 2018-03-02T00:14:22Z

Alright, the arguments to the interpolate call changed (relative -> absolute). Updated the test and docs to match that.

michael-ciniawsky

@jkrems Thx

michael-ciniawsky · 2018-03-02T01:07:13Z

Released in v4.5.0 🎉

hybrist · 2018-03-02T01:11:20Z

Niiice! That was fast! Thanks a lot for the quick review & release. :)

hybrist force-pushed the to-function branch from 741f371 to 8f303a2 Compare March 1, 2018 19:10

hybrist changed the title ~~Add support for toType "function"~~ Add support for regex matches in to templates Mar 1, 2018

hybrist force-pushed the to-function branch from 8f303a2 to f0dae4f Compare March 1, 2018 20:12

michael-ciniawsky changed the title ~~Add support for regex matches in to templates~~ feat(processPattern): add support for {RegExp) matches (patterns.toRegExp) Mar 1, 2018

michael-ciniawsky added type: Feature priority: 5 (nice to have) pr_action: Review status: Pending semver: Minor labels Mar 1, 2018

michael-ciniawsky added this to the 4.5.0 milestone Mar 1, 2018

michael-ciniawsky requested review from alexander-akait, joshwiens and michael-ciniawsky March 1, 2018 21:31

michael-ciniawsky changed the title ~~feat(processPattern): add support for {RegExp) matches (patterns.toRegExp)~~ feat(processPattern): add support for {RegExp) matches (pattern.toRegExp) Mar 1, 2018

michael-ciniawsky suggested changes Mar 1, 2018

View reviewed changes

michael-ciniawsky changed the title ~~feat(processPattern): add support for {RegExp) matches (pattern.toRegExp)~~ feat(processPattern): add support for {RegExp) matches (pattern.test) Mar 1, 2018

hybrist force-pushed the to-function branch from f0dae4f to a110c68 Compare March 1, 2018 22:11

michael-ciniawsky approved these changes Mar 1, 2018

View reviewed changes

hybrist force-pushed the to-function branch from a110c68 to 9ce7794 Compare March 1, 2018 22:16

michael-ciniawsky reviewed Mar 1, 2018

View reviewed changes

hybrist force-pushed the to-function branch from 9ce7794 to 11aa88d Compare March 1, 2018 22:22

feat(processPattern): add support for {RegExp) matches (`pattern.te…

6492640

…st`)

hybrist force-pushed the to-function branch from 11aa88d to 6492640 Compare March 2, 2018 00:12

michael-ciniawsky approved these changes Mar 2, 2018

View reviewed changes

michael-ciniawsky merged commit 1861730 into webpack:master Mar 2, 2018

michael-ciniawsky added status: Approved and removed pr_action: Review priority: 5 (nice to have) status: Pending labels Mar 2, 2018

michael-ciniawsky removed this from the 4.6.0 milestone Mar 2, 2018

hybrist deleted the to-function branch March 2, 2018 01:10

This was referenced Mar 2, 2018

Update copy-webpack-plugin in /site from 4.2.3 to 4.5.0 src-zone/material#401

Closed

Update 5 dependencies from npm storybookjs/storybook#3131

Merged

dependabot-preview bot mentioned this pull request Mar 19, 2018

Bump copy-webpack-plugin from 4.3.0 to 4.5.1 franktopel/vue-defuse#41

Closed


		### `test`

		Defines a regExp to match some parts of the file path.

Uh oh!

feat(processPattern): add support for {RegExp) matches (pattern.test) #235

feat(processPattern): add support for {RegExp) matches (pattern.test) #235

Uh oh!

Conversation

hybrist commented Mar 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jsf-clabot commented Mar 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hybrist commented Mar 1, 2018

Uh oh!

michael-ciniawsky left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

michael-ciniawsky Mar 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hybrist commented Mar 1, 2018

Uh oh!

hybrist commented Mar 1, 2018

Uh oh!

alexander-akait commented Mar 1, 2018

Uh oh!

michael-ciniawsky left a comment

Choose a reason for hiding this comment

Uh oh!

hybrist commented Mar 1, 2018

Uh oh!

michael-ciniawsky left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hybrist commented Mar 2, 2018

Uh oh!

michael-ciniawsky left a comment

Choose a reason for hiding this comment

Uh oh!

michael-ciniawsky commented Mar 2, 2018

Uh oh!

hybrist commented Mar 2, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feat(processPattern): add support for `{RegExp)` matches (`pattern.test`) #235

feat(processPattern): add support for `{RegExp)` matches (`pattern.test`) #235

hybrist commented Mar 1, 2018 •

edited

Loading

jsf-clabot commented Mar 1, 2018 •

edited

Loading

michael-ciniawsky left a comment •

edited

Loading

michael-ciniawsky Mar 1, 2018 •

edited

Loading