Skip to content

Support asyncronous functions in config.url and config.import. #1277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2021
Merged

Support asyncronous functions in config.url and config.import. #1277

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b22e689
Support asyncronous functions in config.url and config.import.
DavidArchibald Mar 20, 2021
f23b110
fix: move await out of loop
DavidArchibald Mar 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Support asyncronous functions in config.url and config.import.
  • Loading branch information
@DavidArchibald
DavidArchibald committed Mar 20, 2021
commit b22e689863773461126e74f122d853e1173236bb
9 changes: 6 additions & 3 deletions src/plugins/postcss-import-parser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,9 +157,12 @@ const plugin = (options = {}) => {
media = valueParser.stringify(mediaNodes).trim().toLowerCase();
}

if (options.filter && !options.filter(normalizedUrl, media)) {
// eslint-disable-next-line no-continue
continue;
if (options.filter) {
const processURL = await options.filter(normalizedUrl, media);
if (!processURL) {
// eslint-disable-next-line no-continue
continue;
}
}

node.remove();
Expand Down
3 changes: 2 additions & 1 deletion src/plugins/postcss-url-parser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,8 @@ const plugin = (options = {}) => {

normalizedUrl = normalizeUrl(normalizedUrl, isStringValue);

if (!options.filter(normalizedUrl)) {
const processUrl = await options.filter(normalizedUrl);
if (!processUrl) {
// eslint-disable-next-line no-continue
continue;
}
Expand Down