Skip to content

publicPath can now be a function #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexander-akait merged 7 commits into from
Apr 8, 2019
Merged

publicPath can now be a function #373

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
098a268
feat: publicPath can now be a function
karlvr Apr 4, 2019
5db65d2
test: publicPath function
karlvr Apr 5, 2019
fab158d
fix: lack of trailing slash on publicPath string option
karlvr Apr 5, 2019
a9985d8
chore: rename function-publicpath test
karlvr Apr 5, 2019
0f76012
feat: test case checker supports nested directories
karlvr Apr 5, 2019
9ef1de0
fix: publicpath-function test demonstrates purpose
karlvr Apr 5, 2019
1b691ab
fix: publicpath-function test demonstrates variable publicPath
karlvr Apr 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: publicpath-function test demonstrates variable publicPath 
Added a second entry point / output at different nesting demonstrating the application of the publicPath function
  • Loading branch information
@karlvr
karlvr committed Apr 5, 2019
commit 1b691abf23ef62c45888eba50687b4e282baca65
2 changes: 2 additions & 0 deletions test/cases/publicpath-function/expected/nested/again/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
body { background: green; background-image: url(../../cd0bb358c45b584743d8ce4991777c42.svg); }

1 change: 1 addition & 0 deletions test/cases/publicpath-function/nested/again/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
body { background: green; background-image: url(../../react.svg); }
2 changes: 2 additions & 0 deletions test/cases/publicpath-function/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ module.exports = {
entry: {
// Specific CSS entry point, with output to a nested folder
'nested/style': './nested/style.css',
// Note that relative nesting of output is the same as that of the input
'nested/again/style': './nested/again/style.css',
},
module: {
rules: [
Expand Down