Skip to content

Conversation

SimonDegraeve
Copy link
Contributor

No description provided.

@ai
Copy link
Contributor

ai commented Nov 12, 2015

Awesome! But can you aslo provide some test for this case? You can look to other test as a sample.

@SimonDegraeve
Copy link
Contributor Author

Done and rebased ;-)

@ai
Copy link
Contributor

ai commented Nov 12, 2015

Sorry, that I add more and more sub tasks :). But it is really awesome feature :).

Can you asl add some docs (my English is bad) about it. I think many users can miss this awesome way to use PostCSS.

Add test

Restore package.json formating

Update Readme.md
@SimonDegraeve
Copy link
Contributor Author

Done.

(my English is bad)

Well, I am French, so mine too...

@ai
Copy link
Contributor

ai commented Nov 12, 2015

:D

ai added a commit that referenced this pull request Nov 12, 2015
@ai ai merged commit d2b8f39 into webpack:master Nov 12, 2015
@SimonDegraeve
Copy link
Contributor Author

For the record, I am using postcss-js because I am working on an implementation of material design with React.

I am not a big fan of inline styles and all their cons (media-query, pseudo-element, prefix, etc). Of course many modules solve them (or try to) but the performance are not good enough for me (and my company). Check Material UI on mobile...

And for theming, I have been trying to achieve my goal with css-modules-values, postcss-functions, postcss-simple-vars, etc... but none was a good fit.

So after weeks of trying different approach, I think having all power of JS with postcss-js and then css-modules for composability and pattern is a real win.

@ai
Copy link
Contributor

ai commented Nov 12, 2015

Yeap. There was Styling project. But seems like it doesn’t need anymore.

@SimonDegraeve
Copy link
Contributor Author

Indeed, I am glad I finally found my dream stack.

@ai
Copy link
Contributor

ai commented Nov 12, 2015

I will release version right after move project to AVA

@SimonDegraeve
Copy link
Contributor Author

Actually I just realised that in the readme the reference to postcssImport in the postcss-js example is useless. Damn copy/paste.

@ai
Copy link
Contributor

ai commented Nov 12, 2015

fixed :)

@ai
Copy link
Contributor

ai commented Nov 12, 2015

Released in 0.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants