Skip to content

Conversation

@Legends
Copy link
Member

@Legends Legends commented Jun 14, 2018

What kind of change does this PR introduce?
AutomaticPrefetchPlugin typings added

Did you add tests for your changes?
no

Does this PR introduce a breaking change?
no

What needs to be documented once your changes are merged?
no

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This need to be documented (issue in webpack/webpack.js.org will be filed when merged)

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

class AutomaticPrefetchPlugin {
/**
* Apply the plugin
* @param {TODO} compiler Webpack Compiler
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO -> Compiler

@webpack-bot
Copy link
Contributor

@Legends Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@sokra Please review the new changes.

@Legends
Copy link
Member Author

Legends commented Jun 21, 2018

@sokra done

@sokra sokra merged commit 4fc03e1 into webpack:master Jun 22, 2018
@sokra
Copy link
Member

sokra commented Jun 22, 2018

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants