🐛 --cache changes behavior around unlisted dependencies and unused files

[JoshuaKGoldberg]

Prerequisites

• I'm using the latest version
• I've read the relevant documentation
• I've searched for existing issues
• I've checked the list of known issues
• I've read the issue reproduction guide

Reproduction url

mochajs/mocha#5394

Reproduction access

• I've made sure the reproduction is publicly accessible

Description of the issue

Running Knip with or without --cache is giving different reports.

Setup:

gh repo clone https://github.com/mochajs/mocha
cd mocha
gh pr checkout 5394
npm i

Locally without cache:

joshgoldberg ~/repos/mocha $ npx knip
Analyzing workspace…
Unlisted dependencies (1)
webpack-cli  test/browser-specific/fixtures/webpack/webpack.config.js

Locally with cache:

joshgoldberg ~/repos/mocha $ npx knip --cache
Unused files (1)
lib/nodejs/worker.js  

In CI with cache:

CI mode enabled
Github Actions detected
output dir: /tmp/mocha-test-webpack
Unlisted dependencies (1)
webpack-cli  test/browser-specific/fixtures/webpack/webpack.config.js

Spooky! 👻

[webpro]

Thanks for the report, Josh! The issue was two-fold: the require.resolved wasn't cached at all, and same for the config file as an entry file. Hopefully things are refactored for the better now, should go out shortly.

[webpro]

🚀 This issue has been resolved in v5.61.3. See Release 5.61.3 for release notes.

Using Knip in a commercial project? Please consider becoming a sponsor.