Reverted change in the react-router plugin on windows #1130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webpro
approved these changes
Jun 10, 2025
| @@ -47,7 +48,7 @@ const resolveConfig: ResolveConfig<PluginConfig> = async (localConfig, options) | |||
| // See: | |||
| // - https://reactrouter.com/how-to/file-route-conventions#optional-segments | |||
| // - https://www.npmjs.com/package/fast-glob#advanced-syntax | |||
| .map(route => route.replace(/[$^*+?()\[\]]/g, '\\$&')); | |||
| .map(route => os.platform() === "win32" ? route : route.replace(/[$^*+?()\[\]]/g, '\\$&')); | |||
There was a problem hiding this comment.
Suggested change
| .map(route => os.platform() === "win32" ? route : route.replace(/[$^*+?()\[\]]/g, '\\$&')); | |
| .map(route => isWindows ? route : route.replace(/[$^*+?()\[\]]/g, '\\$&')); |
| @@ -5,6 +5,7 @@ import { join } from '../../util/path.js'; | |||
| import { hasDependency, load } from '../../util/plugin.js'; | |||
| import vite from '../vite/index.js'; | |||
| import type { PluginConfig, RouteConfigEntry } from './types.js'; | |||
| import os from 'node:os'; | |||
There was a problem hiding this comment.
Suggested change
| import os from 'node:os'; | |
| import os from 'node:os'; | |
| const isWindows = os.platform() === 'win32'; |
commit: |
webpro
reviewed
Jun 11, 2025
Co-authored-by: Lars Kappert <[email protected]>
|
Thanks, Alem! 🙏 |
|
🚀 This pull request is included in v5.61.0. See Release 5.61.0 for release notes. Using Knip in a commercial project? Please consider becoming a sponsor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to this bug fix: #988 the entries on Windows are completely broken due to a transform happening midway between the plugin and the final resolver which turns the escaped \ \ into /.
I couldn't pinpoint the exact cause, and this fix mostly covers the issues on Windows, the only thing that won't work is the ( ) escape.