Skip to content

Conversation

@jonahsnider
Copy link
Contributor

Closes #235

@jonahsnider jonahsnider changed the title Fix entry points for Next.js plugin when using Next.js app router Fix entrypoints for Next.js plugin when using Next.js app router Sep 12, 2023
@webpro
Copy link
Member

webpro commented Sep 12, 2023

Thanks @jonahsnider! Any chance you could maybe add some test coverage as well?

@jonahsnider
Copy link
Contributor Author

Yes, I can try adding some today/tomorrow most likely.

@jonahsnider
Copy link
Contributor Author

@webpro Added some tests, please let me know if there's anything else I should change

@webpro
Copy link
Member

webpro commented Sep 14, 2023

Thanks! This is great, will release shortly

@webpro webpro merged commit f345663 into webpro-nl:main Sep 14, 2023
@jonahsnider jonahsnider deleted the fix-next-plugin branch September 14, 2023 07:51
@webpro
Copy link
Member

webpro commented Sep 14, 2023

🚀 This pull request is included in v2.24.1. See Release 2.24.1 for release notes.

@webpro
Copy link
Member

webpro commented Sep 14, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unused exports are never detected with Next.js plugin in app router projects

2 participants