fix: isFile/isDirectory edge cases

[sinisterstumble]

Closes #634

[webpro]

Thanks @markmartirosian. Yeah let's try a try-catch, this feels a bit redundant.

[sinisterstumble]

@webpro done

[webpro]

I meant try-catch only at the new call-site, here it's not necessary with the no-throw options

[sinisterstumble]

@webpro isn't this scenario general? Here's an illustration, '.profile' is a regular file.

> const fs = require('fs')
> fs.statSync('.profile/excludes', { throwIfNoEntry: false })
Uncaught Error: ENOTDIR: not a directory, stat '.profile/excludes'
    at Object.statSync (node:fs:1659:25) {
  errno: -20,
  code: 'ENOTDIR',
  syscall: 'stat',
  path: '.profile/excludes'
}

[webpro]

Isn't it odd, are we being lied to by throwIfNoEntry: false? I guess you're not on a Node version that does not support that option yet?

Then we could just do without this option?

[sinisterstumble]

@webpro yes very unexpected, I'm on v21.7.1 and given the versions in the screenshot this seems to be the intended behavior.

[sinisterstumble]

@webpro made the changes

[webpro]

Thanks @markmartirosian! Good stuff.

[webpro]

🚀 This pull request is included in v5.17.0-canary.0. See Release 5.17.0-canary.0 for release notes.

Using Knip in a commercial project? Please consider sponsoring me.