Skip to content

Fix iterating over namespaces imported using '*' (star) reporting unused classes #898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
webpro merged 8 commits into from
Jan 5, 2025
Merged

Fix iterating over namespaces imported using '*' (star) reporting unused classes #898

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e48206c
Fix iterating over namespaces imported using '*' (star) reporting unu…
heystewart Dec 30, 2024
82f7957
not needed
heystewart Dec 30, 2024
566909f
When in Rome...
heystewart Dec 30, 2024
1e76888
format
heystewart Dec 30, 2024
8e1a996
removing comment change since I couldn't prove this was true
heystewart Dec 30, 2024
08043a5
revert
heystewart Jan 4, 2025
fe2aab9
Merge branch 'main' into iteration
heystewart Jan 4, 2025
d34e32e
format ... an eslintrc would be nice
heystewart Jan 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removing comment change since I couldn't prove this was true
  • Loading branch information
@heystewart
heystewart committed Dec 30, 2024
commit 8e1a99610a6da3232e18a15cbb26db5731f6b19a
5 changes: 1 addition & 4 deletions packages/knip/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,10 +463,7 @@ export const main = async (unresolvedConfiguration: CommandLineOptions) => {

if (isReferenced) {
if (report.enumMembers && exportedItem.type === 'enum') {
if (importsForExport.refs.has(identifier)) {
// consider members referenced (isObjectEnumerationCallExpressionArgument, isIteratingObject)
continue;
}
if (importsForExport.refs.has(identifier)) continue; // consider members referenced (isObjectEnumerationCallExpressionArgument)

for (const member of exportedItem.members) {
if (findMatch(workspace.ignoreMembers, member.identifier)) continue;
Expand Down