fix clippy warnings

examples/broadcast/broadcast.rs

@@ -157,7 +157,7 @@ async fn main() -> Result<()> {
                     tokio::spawn(async move {
                         // Create Track that we send video back to browser on
                         let local_track = Arc::new(TrackLocalStaticRTP::new(
-                            track.codec().await.capability.clone(),
+                            track.codec().await.capability,
                             "video".to_owned(),
                             "webrtc-rs".to_owned(),
                         ));
@@ -186,7 +186,7 @@ async fn main() -> Result<()> {
     // This will notify you when the peer has connected/disconnected
     peer_connection
         .on_peer_connection_state_change(Box::new(move |s: RTCPeerConnectionState| {
-            print!("Peer Connection State has changed: {}\n", s);
+            println!("Peer Connection State has changed: {}", s);
             Box::pin(async {})
         }))
         .await;
@@ -274,7 +274,7 @@ async fn main() -> Result<()> {
             // This will notify you when the peer has connected/disconnected
             peer_connection
                 .on_peer_connection_state_change(Box::new(move |s: RTCPeerConnectionState| {
-                    print!("Peer Connection State has changed: {}\n", s);
+                    println!("Peer Connection State has changed: {}", s);
                     Box::pin(async {})
                 }))
                 .await;

examples/data-channels-close/data-channels-close.rs

@@ -143,7 +143,7 @@ async fn main() -> Result<()> {
             Box::pin(async move {
                 let d2 = Arc::clone(&d);
                 let d_label2 = d_label.clone();
-                let d_id2 = d_id.clone();
+                let d_id2 = d_id;
                 d.on_open(Box::new(move || {
                     println!("Data channel '{}'-'{}' open. Random messages will now be sent to any connected DataChannels every 5 seconds", d_label2, d_id2);
                     let (done_tx, mut done_rx) = tokio::sync::mpsc::channel::<()>(1);
@@ -187,7 +187,7 @@ async fn main() -> Result<()> {
                 // Register text message handling
                 d.on_message(Box::new(move |msg: DataChannelMessage| {
                     let msg_str = String::from_utf8(msg.data.to_vec()).unwrap();
-                    print!("Message from DataChannel '{}': '{}'\n", d_label, msg_str);
+                    println!("Message from DataChannel '{}': '{}'", d_label, msg_str);
                     Box::pin(async {})
                 })).await;
             })

examples/data-channels-detach/data-channels-detach.rs

@@ -136,7 +136,7 @@ async fn main() -> Result<()> {
             Box::pin(async move {
                 let d2 = Arc::clone(&d);
                 let d_label2 = d_label.clone();
-                let d_id2 = d_id.clone();
+                let d_id2 = d_id;
                 d.on_open(Box::new(move || {
                     println!("Data channel '{}'-'{}' open.", d_label2, d_id2);
 

examples/data-channels/data-channels.rs

@@ -124,7 +124,7 @@ async fn main() -> Result<()> {
             Box::pin(async move {
                 let d2 = Arc::clone(&d);
                 let d_label2 = d_label.clone();
-                let d_id2 = d_id.clone();
+                let d_id2 = d_id;
                 d.on_open(Box::new(move || {
                     println!("Data channel '{}'-'{}' open. Random messages will now be sent to any connected DataChannels every 5 seconds", d_label2, d_id2);
 
@@ -148,7 +148,7 @@ async fn main() -> Result<()> {
                 // Register text message handling
                 d.on_message(Box::new(move |msg: DataChannelMessage| {
                     let msg_str = String::from_utf8(msg.data.to_vec()).unwrap();
-                    print!("Message from DataChannel '{}': '{}'\n", d_label, msg_str);
+                    println!("Message from DataChannel '{}': '{}'", d_label, msg_str);
                     Box::pin(async {})
                 })).await;
             })

examples/insertable-streams/insertable-streams.rs

@@ -205,7 +205,7 @@ async fn main() -> Result<()> {
     // This will notify you when the peer has connected/disconnected
     peer_connection
         .on_peer_connection_state_change(Box::new(move |s: RTCPeerConnectionState| {
-            print!("Peer Connection State has changed: {}\n", s);
+            println!("Peer Connection State has changed: {}", s);
 
             if s == RTCPeerConnectionState::Failed {
                 // Wait until PeerConnection has had no network activity for 30 seconds or another failure. It may be reconnected using an ICE Restart.

examples/offer-answer/answer.rs

@@ -149,7 +149,7 @@ async fn remote_handler(req: Request<Body>) -> Result<Response<Body>, hyper::Err
                 Ok(resp) => resp,
                 Err(err) => {
                     println!("{}", err);
-                    return Err(err.into());
+                    return Err(err);
                 }
             };
             //println!("remote_handler Response: {}", resp.status());
@@ -348,7 +348,7 @@ async fn main() -> Result<()> {
             // Register channel opening handling
             let d2 =  Arc::clone(&d);
             let d_label2 = d_label.clone();
-            let d_id2 = d_id.clone();
+            let d_id2 = d_id;
             d.on_open(Box::new(move || {
                 println!("Data channel '{}'-'{}' open. Random messages will now be sent to any connected DataChannels every 5 seconds", d_label2, d_id2);
                 Box::pin(async move {
@@ -371,7 +371,7 @@ async fn main() -> Result<()> {
             // Register text message handling
             d.on_message(Box::new(move |msg: DataChannelMessage| {
                let msg_str = String::from_utf8(msg.data.to_vec()).unwrap();
-               print!("Message from DataChannel '{}': '{}'\n", d_label, msg_str);
+               println!("Message from DataChannel '{}': '{}'", d_label, msg_str);
                Box::pin(async{})
            })).await;
         })

examples/ortc/ortc.rs

@@ -104,7 +104,7 @@ async fn main() -> Result<()> {
         Box::pin(async move {
             let d2 = Arc::clone(&d);
             let d_label2 = d_label.clone();
-            let d_id2 = d_id.clone();
+            let d_id2 = d_id;
             d.on_open(Box::new(move || {
                 println!("Data channel '{}'-'{}' open. Random messages will now be sent to any connected DataChannels every 5 seconds", d_label2, d_id2);
 
@@ -116,7 +116,7 @@ async fn main() -> Result<()> {
             // Register text message handling
             d.on_message(Box::new(move |msg: DataChannelMessage| {
                 let msg_str = String::from_utf8(msg.data.to_vec()).unwrap();
-                print!("Message from DataChannel '{}': '{}'\n", d_label, msg_str);
+                println!("Message from DataChannel '{}': '{}'", d_label, msg_str);
                 Box::pin(async {})
             })).await;
         })
@@ -204,7 +204,7 @@ async fn main() -> Result<()> {
         let d_label = d.label().to_owned();
         d.on_message(Box::new(move |msg: DataChannelMessage| {
             let msg_str = String::from_utf8(msg.data.to_vec()).unwrap();
-            print!("Message from DataChannel '{}': '{}'\n", d_label, msg_str);
+            println!("Message from DataChannel '{}': '{}'", d_label, msg_str);
             Box::pin(async {})
         }))
         .await;

examples/play-from-disk-renegotiation/play-from-disk-renegotiation.rs

@@ -323,7 +323,7 @@ async fn main() -> Result<()> {
     // This will notify you when the peer has connected/disconnected
     peer_connection
         .on_peer_connection_state_change(Box::new(move |s: RTCPeerConnectionState| {
-            print!("Peer Connection State has changed: {}\n", s);
+            println!("Peer Connection State has changed: {}", s);
 
             if s == RTCPeerConnectionState::Failed {
                 // Wait until PeerConnection has had no network activity for 30 seconds or another failure. It may be reconnected using an ICE Restart.

examples/play-from-disk-vp8/play-from-disk-vp8.rs

@@ -288,7 +288,7 @@ async fn main() -> Result<()> {
     // This will notify you when the peer has connected/disconnected
     peer_connection
         .on_peer_connection_state_change(Box::new(move |s: RTCPeerConnectionState| {
-            print!("Peer Connection State has changed: {}\n", s);
+            println!("Peer Connection State has changed: {}", s);
 
             if s == RTCPeerConnectionState::Failed {
                 // Wait until PeerConnection has had no network activity for 30 seconds or another failure. It may be reconnected using an ICE Restart.

examples/rtp-forwarder/rtp-forwarder.rs

@@ -266,7 +266,7 @@ async fn main() -> Result<()> {
     // This will notify you when the peer has connected/disconnected
     peer_connection
         .on_peer_connection_state_change(Box::new(move |s: RTCPeerConnectionState| {
-            print!("Peer Connection State has changed: {}\n", s);
+            println!("Peer Connection State has changed: {}", s);
 
             if s == RTCPeerConnectionState::Failed {
                 // Wait until PeerConnection has had no network activity for 30 seconds or another failure. It may be reconnected using an ICE Restart.

examples/rtp-to-webrtc/rtp-to-webrtc.rs

@@ -142,7 +142,7 @@ async fn main() -> Result<()> {
     // This will notify you when the peer has connected/disconnected
     peer_connection
         .on_peer_connection_state_change(Box::new(move |s: RTCPeerConnectionState| {
-            print!("Peer Connection State has changed: {}\n", s);
+            println!("Peer Connection State has changed: {}", s);
 
             if s == RTCPeerConnectionState::Failed {
                 // Wait until PeerConnection has had no network activity for 30 seconds or another failure. It may be reconnected using an ICE Restart.

examples/swap-tracks/swap-tracks.rs

@@ -213,7 +213,7 @@ async fn main() -> Result<()> {
     let done1 = Arc::clone(&done);
     peer_connection
         .on_peer_connection_state_change(Box::new(move |s: RTCPeerConnectionState| {
-            print!("Peer Connection State has changed: {}\n", s);
+            println!("Peer Connection State has changed: {}", s);
 
             let done2 = Arc::clone(&done1);
             Box::pin(async move {

src/api/media_engine.rs

@@ -406,7 +406,7 @@ impl MediaEngine {
                 MediaEngine::add_codec(&mut self.video_codecs, codec);
                 Ok(())
             }
-            _ => Err(Error::ErrUnknownType.into()),
+            _ => Err(Error::ErrUnknownType),
         }
     }
 
@@ -429,7 +429,7 @@ impl MediaEngine {
             if *direction != RTCRtpTransceiverDirection::Recvonly
                 && *direction != RTCRtpTransceiverDirection::Sendonly
             {
-                return Err(Error::ErrRegisterHeaderExtensionInvalidDirection.into());
+                return Err(Error::ErrRegisterHeaderExtensionInvalidDirection);
             }
         }
 
@@ -529,7 +529,7 @@ impl MediaEngine {
             }
         }
 
-        Err(Error::ErrCodecNotFound.into())
+        Err(Error::ErrCodecNotFound)
     }
 
     /*TODO: func (m *MediaEngine) collectStats(collector *statsReportCollector) {

src/api/mod.rs

@@ -87,7 +87,7 @@ impl API {
             let now = SystemTime::now();
             for cert in &certificates {
                 if cert.expires().duration_since(now).is_err() {
-                    return Err(Error::ErrCertificateExpired.into());
+                    return Err(Error::ErrCertificateExpired);
                 }
             }
         } else {
@@ -126,7 +126,7 @@ impl API {
     ) -> Result<RTCDataChannel> {
         // https://w3c.github.io/webrtc-pc/#peer-to-peer-data-api (Step #5)
         if params.label.len() > 65535 {
-            return Err(Error::ErrStringSizeLimit.into());
+            return Err(Error::ErrStringSizeLimit);
         }
 
         let d = RTCDataChannel::new(params, Arc::clone(&self.setting_engine));

src/api/setting_engine.rs

@@ -199,7 +199,7 @@ impl SettingEngine {
     ///   Act as dtls_transport Server, wait for ClientHello
     pub fn set_answering_dtls_role(&mut self, role: DTLSRole) -> Result<()> {
         if role != DTLSRole::Client && role != DTLSRole::Server {
-            return Err(Error::ErrSettingEngineSetAnsweringDTLSRole.into());
+            return Err(Error::ErrSettingEngineSetAnsweringDTLSRole);
         }
 
         self.answering_dtls_role = role;

src/data/data_channel/mod.rs

@@ -178,7 +178,7 @@ impl RTCDataChannel {
 
             Ok(())
         } else {
-            Err(Error::ErrSCTPNotEstablished.into())
+            Err(Error::ErrSCTPNotEstablished)
         }
     }
 
@@ -338,7 +338,7 @@ impl RTCDataChannel {
         if let Some(dc) = &*data_channel {
             Ok(dc.write_data_channel(data, false).await?)
         } else {
-            Err(Error::ErrClosedPipe.into())
+            Err(Error::ErrClosedPipe)
         }
     }
 
@@ -350,13 +350,13 @@ impl RTCDataChannel {
         if let Some(dc) = &*data_channel {
             Ok(dc.write_data_channel(&Bytes::from(s), true).await?)
         } else {
-            Err(Error::ErrClosedPipe.into())
+            Err(Error::ErrClosedPipe)
         }
     }
 
     fn ensure_open(&self) -> Result<()> {
         if self.ready_state() != RTCDataChannelState::Open {
-            Err(Error::ErrClosedPipe.into())
+            Err(Error::ErrClosedPipe)
         } else {
             Ok(())
         }
@@ -372,7 +372,7 @@ impl RTCDataChannel {
     /// resulting DataChannel object.
     pub async fn detach(&self) -> Result<Arc<data::data_channel::DataChannel>> {
         if !self.setting_engine.detach.data_channels {
-            return Err(Error::ErrDetachNotEnabled.into());
+            return Err(Error::ErrDetachNotEnabled);
         }
 
         let data_channel = self.data_channel.lock().await;
@@ -381,7 +381,7 @@ impl RTCDataChannel {
 
             Ok(Arc::clone(dc))
         } else {
-            Err(Error::ErrDetachBeforeOpened.into())
+            Err(Error::ErrDetachBeforeOpened)
         }
     }
 

src/data/sctp_transport/mod.rs

@@ -166,7 +166,7 @@ impl RTCSctpTransport {
 
             Ok(())
         } else {
-            Err(Error::ErrSCTPTransportDTLS.into())
+            Err(Error::ErrSCTPTransportDTLS)
         }
     }
 
@@ -366,7 +366,7 @@ impl RTCSctpTransport {
             }
         }
 
-        Err(Error::ErrMaxDataChannelID.into())
+        Err(Error::ErrMaxDataChannelID)
     }
 
     pub(crate) async fn association(&self) -> Option<Arc<Association>> {

src/media/dtls_transport/mod.rs

@@ -185,7 +185,7 @@ impl RTCDtlsTransport {
                 .extract_session_keys_from_dtls(conn_state, self.role().await == DTLSRole::Client)
                 .await?;
         } else {
-            return Err(Error::ErrDtlsTransportNotStarted.into());
+            return Err(Error::ErrDtlsTransportNotStarted);
         }
 
         {
@@ -225,7 +225,7 @@ impl RTCDtlsTransport {
                 .extract_session_keys_from_dtls(conn_state, self.role().await == DTLSRole::Client)
                 .await?;
         } else {
-            return Err(Error::ErrDtlsTransportNotStarted.into());
+            return Err(Error::ErrDtlsTransportNotStarted);
         }
 
         {
@@ -301,7 +301,7 @@ impl RTCDtlsTransport {
         self.ensure_ice_conn()?;
 
         if self.state() != RTCDtlsTransportState::New {
-            return Err(Error::ErrInvalidDTLSStart.into());
+            return Err(Error::ErrInvalidDTLSStart);
         }
 
         {
@@ -320,7 +320,7 @@ impl RTCDtlsTransport {
         let certificate = if let Some(cert) = self.certificates.first() {
             cert.certificate.clone()
         } else {
-            return Err(Error::ErrNonCertificate.into());
+            return Err(Error::ErrNonCertificate);
         };
         self.state_change(RTCDtlsTransportState::Connecting).await;
 
@@ -399,7 +399,7 @@ impl RTCDtlsTransport {
                 }
                 _ => {
                     self.state_change(RTCDtlsTransportState::Failed).await;
-                    return Err(Error::ErrNoSRTPProtectionProfile.into());
+                    return Err(Error::ErrNoSRTPProtectionProfile);
                 }
             };
         }
@@ -415,7 +415,7 @@ impl RTCDtlsTransport {
         let remote_certs = &dtls_conn.connection_state().await.peer_certificates;
         if remote_certs.is_empty() {
             self.state_change(RTCDtlsTransportState::Failed).await;
-            return Err(Error::ErrNoRemoteCertificate.into());
+            return Err(Error::ErrNoRemoteCertificate);
         }
 
         {
@@ -502,7 +502,7 @@ impl RTCDtlsTransport {
         let remote_parameters = self.remote_parameters.lock().await;
         for fp in &remote_parameters.fingerprints {
             if fp.algorithm != "sha-256" {
-                return Err(Error::ErrUnsupportedFingerprintAlgorithm.into());
+                return Err(Error::ErrUnsupportedFingerprintAlgorithm);
             }
 
             let mut h = Sha256::new();
@@ -516,12 +516,12 @@ impl RTCDtlsTransport {
             }
         }
 
-        Err(Error::ErrNoMatchingCertificateFingerprint.into())
+        Err(Error::ErrNoMatchingCertificateFingerprint)
     }
 
     pub(crate) fn ensure_ice_conn(&self) -> Result<()> {
         if self.ice_transport.state() == RTCIceTransportState::New {
-            Err(Error::ErrICEConnectionNotStarted.into())
+            Err(Error::ErrICEConnectionNotStarted)
         } else {
             Ok(())
         }