Skip to content

Conversation

ams-tschoening
Copy link
Contributor

The section "'Installation" has been enhanced to document the new environment variable WEBSVN_PATH_CONF introduced by websvnphp/websvn#87 and the newly implemented simple layering of configs.

One problem I recognized is that we only have one web site with one installation instructions for the latest released version of the software. So in theory one can only merge this directly before releasing a new version, which sounds pretty error prone to me. Not sure how to handle this, in the easiest case we simply merge and don't think about such things too much. :-)

@ams-tschoening ams-tschoening requested a review from michael-o June 20, 2019 06:55
@michael-o
Copy link
Member

Looking into it.

Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires some fixes, but in general it is quite decent

etc. would be set in <code>include/config.php</code>. That allows structuring SVN-repos in
subdirs like supported by <code>svnserve</code>, which is otherwise not supported by WebSVN,
as it checks if each directory is an SVN-repo already or simply ignores it. The following is
a more complete example:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is comparative of complete, it is either complete or incomplete

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "comprehensive" a better term? The example doesn't contain everything, only more htan the former one. Or better use "verbose"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comprehensive is good.

Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nits remaining

@ams-tschoening ams-tschoening merged commit d8a1e98 into master Jun 21, 2019
@ams-tschoening ams-tschoening deleted the ghi_86_conf_by_env_var branch June 21, 2019 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants