-
Notifications
You must be signed in to change notification settings - Fork 3
Enhanced "Installation" to document WEBSVN_PATH_CONF. #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looking into it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requires some fixes, but in general it is quite decent
docs/install.html
Outdated
etc. would be set in <code>include/config.php</code>. That allows structuring SVN-repos in | ||
subdirs like supported by <code>svnserve</code>, which is otherwise not supported by WebSVN, | ||
as it checks if each directory is an SVN-repo already or simply ignores it. The following is | ||
a more complete example: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is comparative of complete, it is either complete or incomplete
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is "comprehensive" a better term? The example doesn't contain everything, only more htan the former one. Or better use "verbose"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comprehensive is good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just nits remaining
The section "'Installation" has been enhanced to document the new environment variable
WEBSVN_PATH_CONF
introduced by websvnphp/websvn#87 and the newly implemented simple layering of configs.One problem I recognized is that we only have one web site with one installation instructions for the latest released version of the software. So in theory one can only merge this directly before releasing a new version, which sounds pretty error prone to me. Not sure how to handle this, in the easiest case we simply merge and don't think about such things too much. :-)