fixed bugs #62
Closed
fixed bugs #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 20, 2016 16:32
fix #1: shift click a checkbox only check itself instead of checking the rest of the checkboxes if there isn't a last checkbox already fix #2: unchecking a checkbox doesn't assign the checkbox to the lastChecked variable fix #3: when selecting multiple checkboxes in the opposite direction of the last multiple checkboxes selection, the new selection is made from the lastCheckbox variable of the previous selection instead of the current selection. (e.g: selecting checkbox5 and selecting checkbox9 will select checkbox5,6,7,8,9, after that selecting checkbox1 will only select checkbox1,2,3,4,5 and uncheck 6,7,8,9 instead of checking 1 all the way to 9) fix #4: shift-click on an already checked checkbox uncheck the checkbox instead checking the rest of the checkboxes
Owner
|
I appreciate the PR but I will be keeping these files the same as the videos in order to maintain consistency. Thanks though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1: shift click a checkbox only check itself instead of checking the rest of the checkboxes if there wasn't a last checkbox already
fix #2: unchecking a checkbox doesn't assign the checkbox to the lastChecked variable
fix #3: when selecting multiple checkboxes in the opposite direction of the last multiple checkboxes selection, the new selection is made from the lastCheckbox variable of the previous selection instead of the current selection. (e.g: selecting checkbox5 and selecting checkbox9 will select checkbox5,6,7,8,9, after that selecting checkbox1 will only select checkbox1,2,3,4,5 and uncheck 6,7,8,9 instead of checking 1 all the way to 9.)
fix #4: shift-click on an already checked checkbox uncheck the checkbox instead checking the rest of the checkboxes