Fix: prefix all commands in forgit.plugin.zsh

[sandr01d]

Check list

• I have performed a self-review of my code
• I have commented my code in hard-to-understand areas
• I have made corresponding changes to the documentation

Description

Closes #435

Fish does not seem to be affected by this issue, so no changes necessary there.

Type of change

• Bug fix
• New feature
• Refactor
• Breaking change
• Documentation change

Test environment

• Shell
  • bash
  • zsh
  • fish
• OS
  • Linux
  • Mac OS X
  • Windows
  • Others:

[carlfriedrich]

Thanks for the fix @sandr01d!

I must confess, I actually don't like the \<command> syntax.

First (very subjective) argument is that I have never heard of this before. In contrast, using command as a prefix is a very common thing to do for me, even interactively, and in my perception this is the common way to do handle this (I might be wrong, though).

Second (kind of objective) argument is that people who don't know this syntax will have a hard time figuring out what it does, as this is difficult to google.

So I would still vote for prefixing everything with command.

A third approach (which I still like more than the backslash syntax) would be to call every command via its absolute path. The path could be found with which, so for example printf would become $(which printf).
This would not work for shell built-ins, though (set, unset, alias, export). However, I would consider it very unlikely that someone has aliased a shell built-in. We're not escaping if, then or while either, so I would vote against escaping built-ins in general.

Either way I would vote for adding a describing comment to the plugin on why we do this.

[sandr01d]

@carlfriedrich I've made changes accordingly. command does not support shell built-ins either, so I used builtin for those as pointed out in #435 (comment).

[carlfriedrich]

Thanks a lot for the update @sandr01d. I like this a lot more! LGTM.