Tweak [CEReactions] definition and usage #2378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes #2362, by: * Making it clearer that the steps inserted by [CEReactions] apply before/after what Web IDL calls "the actions listed in the description of" a given construct. * Removing [CEReactions] from [PutForwards]-decorated readonly attributes, as it is redundant there.
domenic
added
the
topic: custom elements
annevk
approved these changes
Feb 22, 2017
|
It appears to me that we don't have tests for these attributes in custom elements. Someone should add those test cases. Unfortunately, I'm too busy with other things right now. |
Member
Author
|
Well, kind of the point of this PR is that they are covered by https://github.com/w3c/web-platform-tests/blob/master/custom-elements/reactions/DOMTokenList.html, but yeah, that assumes you implement the Web IDL bindings correctly for [PutForwards]... |
|
I think we should add tests for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2362, by:
before/after what Web IDL calls "the actions listed in the description
of" a given construct.
attributes, as it is redundant there.
/cc @bzbarsky (review probably not required if you're busy though; it's a simple change)