Skip to content

Conversation

derhofbauer
Copy link

This PR adds the option to anonymize IPs in the Google Analytics pre-configured cookie group.

Right now it is possible to add the anonymize IP config to the Google Analytics snippet by duplicating the GA cookie group, but it would be way nicer an easier to just have this option on the AnalyticCookiesCategory::google() method. This feature is also requested in #51.

The readme claims that the package is fully GDPR compliant, which it was not, up until the point where google analytics could have the anonymize IP setting enabled.

  • Add $anonymizeIp param to AnalyticCookiesCategory::google() method
  • Update Readme
  • Update CookiesServiceProvider.php stub

Please let me know if you have anything you want updated in my PR.

Alexander Hofbauer added 2 commits July 22, 2024 11:30
…ics to conform to GDPR, fixes whitecube#51

* Add `$anonymizeIp` param to `AnalyticCookiesCategory::google()` method
* Update Readme
* Update CookiesServiceProvider.php stub
…ry.php

str_starts_with() was introduced in PHP8, composer.json file mentions minimum PHP version 8.1, so this should work.
Copy link
Member

@toonvandenbos toonvandenbos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks!

@toonvandenbos toonvandenbos merged commit 355d7fd into whitecube:main Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants