Skip to content

Refactor js classes #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Debatty-Tom wants to merge 16 commits into
base: 2.x
Choose a base branch
from
Open

Refactor js classes #96

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
ea77af8
Pass json routes by a data attribute
Debatty-Tom Oct 3, 2025
6d646e8
refactor js files
Debatty-Tom Oct 3, 2025
9cc83af
fix transition with js
Debatty-Tom Oct 3, 2025
99f7d58
change modal class to an object
Debatty-Tom Oct 7, 2025
3dc9d8a
Refactor to 2 js classes that will be load separately
Debatty-Tom Oct 9, 2025
d07163c
fix animation on page load
Debatty-Tom Oct 9, 2025
fe7d44c
Load the 2 script in the head
Debatty-Tom Oct 9, 2025
1364f68
use a init method instead of the constructor
Debatty-Tom Oct 10, 2025
66fb7ba
make sure we don't define the script 2 times because of the prevent d…
Debatty-Tom Oct 10, 2025
9980fe6
Stored all dom elements inside this.elements object
Debatty-Tom Oct 20, 2025
e8b4872
Refactor routes
Debatty-Tom Oct 20, 2025
1f498bc
Passing modal's translations through the scriptController.
Debatty-Tom Oct 20, 2025
6176e8a
The #cookies-policy element is always hidden with js and I ensure tha…
Debatty-Tom Oct 20, 2025
bc38317
Put the reset/edit logic inside the cookie.js file to keep modal.js o…
Debatty-Tom Oct 21, 2025
2acf670
Pass the translations to the modal script to ensure it loads without …
Debatty-Tom Oct 21, 2025
e3fb3cb
added javascript event after cookie consent action
Debatty-Tom Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix transition with js
  • Loading branch information
@Debatty-Tom
Debatty-Tom committed Oct 9, 2025
commit 9cc83aff2088c55092370a21ad3e5ed34c578b7d
3 changes: 2 additions & 1 deletion dist/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7469,7 +7469,8 @@ if (cookieConsentNotice) {
cookieConsentConfigScript.removeAttribute('data-config');
cookieConsentNotice.removeAttribute('data-text');
setTimeout(function () {
return cookieConsentNotice.classList.remove('cookies--closing');
cookieConsentNotice.classList.remove('cookies--closing');
cookieConsentNotice.style.transitionDuration = "200ms";
}, 110);
});
}
Expand Down
2 changes: 1 addition & 1 deletion dist/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
max-width: 100%;
overflow: auto;
z-index: 9999;
transition: transform 200ms ease-out, opacity 200ms ease-out;
transition: transform 0ms ease-out, opacity 0ms ease-out;
}
#cookies-policy.cookies--closing {
opacity: 0;
Expand Down
5 changes: 4 additions & 1 deletion resources/js/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ if (cookieConsentNotice) {
cookieConsentConfigScript.removeAttribute('data-config');
cookieConsentNotice.removeAttribute('data-text');

setTimeout( () => cookieConsentNotice.classList.remove('cookies--closing'), 110);
setTimeout( () => {
cookieConsentNotice.classList.remove('cookies--closing');
cookieConsentNotice.style.transitionDuration = "200ms";
}, 110);
});
}
4 changes: 2 additions & 2 deletions resources/scss/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
max-width: 100%;
overflow: auto;
z-index: 9999;
transition: transform 200ms ease-out,
opacity 200ms ease-out;
transition: transform 0ms ease-out,
opacity 0ms ease-out;

&--closing {
opacity: 0;
Expand Down