Hide unconfigured services for #1349 #1350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
windingwind
requested changes
Dec 1, 2025
- Add getUnconfiguredServiceIds() to TranslationServices class - Simplify _filterUnconfiguredServices() in panel.ts to use new method - Parse secrets JSON once instead of per-service for better performance - Remove unused getPrefJSON import
windingwind
approved these changes
Dec 6, 2025
Contributor
|
🚀 This ticket has been resolved in v2.4.0-beta.4. See Release v2.4.0-beta.4 for release notes. |
windingwind
pushed a commit
that referenced
this pull request
Dec 6, 2025
* feat: add preference to hide unconfigured services from the menu * feat: update pannel without Zotero restart * refactor: move service configuration check logic to services module - Add getUnconfiguredServiceIds() to TranslationServices class - Simplify _filterUnconfiguredServices() in panel.ts to use new method - Parse secrets JSON once instead of per-service for better performance - Remove unused getPrefJSON import
Contributor
|
🚀 This ticket has been resolved in v2.4.0-beta.4. See Release v2.4.0-beta.4 for release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new user preference to hide unconfigured translation services from the service selection dropdown menu in the item pane. It adds the necessary UI elements, localization strings, default preference value, and logic to filter out services that require configuration but have not been set up by the user.
Preference UI and Localization:
hideUnconfiguredServices) to the preferences UI (preferences.xhtml) allowing users to enable or disable hiding of unconfigured services.Preference Logic and Behavior:
hideUnconfiguredServices(default:false) inprefs.js._filterUnconfiguredServicesmethod inpanel.tsto hide menu items for services that require configuration but are not set up, based on the new preference. The method checks for required secrets and validates them if necessary.