Repository navigation
M2.chart-native: integrate upstream 0.9 and retain chart parts through native saves - #33
Merged
Merged
Conversation
* M2.1: preserve chart parts through native saves Serialize retained chart relationships and payloads in native files. Add native and headless file-command round-trip regressions. Contribution on behalf of @MMexicann. * Format: bound opaque chart parts as native ZIP entries Address maintainer feedback on the existing PR. Preserve upstream work and document tested scope and validation limits. * Model: track transient native chart part entries Address maintainer feedback on the existing PR. Preserve upstream work and document tested scope and validation limits. * PPTX: initialize native chart entry metadata Address maintainer feedback on the existing PR. Preserve upstream work and document tested scope and validation limits. * Engine: adapt chart native roundtrip fixtures Address maintainer feedback on the existing PR. Preserve upstream work and document tested scope and validation limits. * Docs: describe bounded chart sidecars and validation Address maintainer feedback on the existing PR. Preserve upstream work and document tested scope and validation limits. * Roadmap: record bounded chart persistence evidence Address maintainer feedback on the existing PR. Preserve upstream work and document tested scope and validation limits. --------- Co-authored-by: skylar taylor-barrick <hi@skylar.cc>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…erabbit-badges docs: add SonarCloud and CodeRabbit badges to README
Adds .coderabbit.yaml so CodeRabbit no longer reviews or comments on PRs opened by dependabot[bot]. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…flow ci: switch to shared nix workflow from craft-common-actions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Imported charts currently lose their retained workbook/drawing parts when saved through the native format. Integrate upstream through 63831cd (0.9.0 and chart persistence storytold#851), resolving the conflicts from #31 on a fork-owned branch while retaining ChartAxis JSON, legacy .slidecraft files, control authentication, Vietnamese UI, opaque graphs and the portable updater.
Native chart metadata also creates a new producer for retained parts. Bound each chart to 256 package parts and 1,024 direct relationships across native save/load, PPTX capture and export preflight. Reject oversized native/API models explicitly; reserve payload and relationship-sidecar slots together during PPTX capture. Index normalized export companion names once to remove the quadratic lookup. Reuse the unique payload list when rewriting relationships so duplicate logical names cannot cause repeated XML parsing or buffered output; normalized names retain first-entry semantics.
Native save now preflights the same combined media/chart item and payload-byte limits and per-entry sizes as load. Manifest JSON streams into its ZIP member under the same entry cap. Recovery refuses snapshots/metadata above its reader limits before replacing either previous member. Pin the reviewed shared Nix workflow revision to make CI inputs reproducible.
Validation:
Imported chart retention does not create workbooks for new/edited charts (storytold#1047). Upstream authorship is preserved by the merge. Readiness scores remain unchanged.
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Chores