Remove the ssr external for vue#10601
Conversation
🦋 Changeset detectedLatest commit: 248b1ea The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
I'm not 100% sure where this should be landed. Either here or in the adapters PR 🤔 |
Why was |
matthewp
left a comment
There was a problem hiding this comment.
npm packages are external by default, so this is probably a remnant from before that was the case. Seems safe to do, to me.
|
fwiw this package is deprecated anyway as it's now included natively in the Vue package itself. (See https://www.npmjs.com/package/@vue/server-renderer) |
|
@ematipico done...I think...first time committing a changeset |
Changes
Solves Deploying to CF Pages with a Vue Island is broken adapters#207
Testing
Tested the CF Pages deploy and it works now.
Docs